Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix H5P update builds #12977

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix H5P update builds #12977

merged 1 commit into from
Jan 9, 2025

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jan 7, 2025

Summary

  • Fixes two oversights from Auto update h5p #12806
    • Actually installs dependencies for workflow
    • Add JSZip to dependencies

@github-actions github-actions bot added the DEV: dev-ops Continuous integration & deployment label Jan 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0a0.dev0_git.310.gae98a846.pex
Windows Installer (EXE) kolibri-0.18.0a0.dev0+git.310.gae98a846-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0a0.dev0+git.310.gae98a846-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0a0.dev0+git.310.gae98a846.dmg
Android Package (APK) kolibri-0.18.0a0.dev0+git.310.gae98a846-0.1.4-debug.apk
Raspberry Pi Image kolibri-pi-image-0.18.0a0.dev0+git.310.gae98a846.zip
TAR file kolibri-0.18.0a0.dev0+git.310.gae98a846.tar.gz
WHL file kolibri-0.18.0a0.dev0+git.310.gae98a846-py2.py3-none-any.whl

@rtibbles
Add explicit jszip dependency for hashi dev for h5p builds.
87b7012 
Install dependencies when updating h5p builds.
@rtibbles rtibbles force-pushed the you_found_my_yarn_cache branch from 61fb7d4 to 87b7012 Compare January 8, 2025 20:11
nucleogenesis
nucleogenesis approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Richard! LGTM

@rtibbles rtibbles merged commit cb4ec2c into learningequality:develop Jan 9, 2025
37 checks passed
@rtibbles rtibbles deleted the you_found_my_yarn_cache branch January 9, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nucleogenesis nucleogenesis nucleogenesis approved these changes

Assignees
No one assigned
Labels
DEV: dev-ops Continuous integration & deployment
Projects
None yet
Milestone
Kolibri 0.18: General maintenance
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @nucleogenesis